Skip to content

bpo-34523: Use _PyCoreConfig instead of globals #9005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 1 commit into from
Aug 29, 2018
Merged

bpo-34523: Use _PyCoreConfig instead of globals #9005

vstinner merged 1 commit into from
Aug 29, 2018

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Aug 29, 2018 •
edited by bedevere-bot
Loading

Get configuratiom the core configuration of the interpreter, rather
than getting global configuration variables. For example, replace
Py_QuietFlag with core_config->quiet.

https://bugs.python.org/issue34523

@vstinner
bpo-34523: Use _PyCoreConfig instead of globals
748aa6a 
Get configuratiom the core configuration of the interpreter, rather
than getting global configuration variables. For example, replace
Py_QuietFlag with core_config->quiet.
@vstinner vstinner merged commit fbca908 into python:master Aug 29, 2018
@vstinner vstinner deleted the use_config branch August 29, 2018 22:50
@bmwiedemann
Copy link
Contributor

bmwiedemann commented Sep 27, 2018 •
edited
Loading

Unfortunately, the description does not tell much about "Why this is good?" (edit: link went to different PR)
Does it help reduce unexpected influences from other places in code?

@vstinner
Copy link
Member Author

vstinner commented Sep 27, 2018

Unfortunately, the description does not tell much about "Why this is good?" (edit: link went to different PR)
Does it help reduce unexpected influences from other places in code?

For the long term, I plan to deprecate global variables, especially global configuration variables like Py_QuietFlag. Moreover, I would like to support running two Python interpreters inside the same process but with two different configurations.

See https://www.python.org/dev/peps/pep-0554/ for more information about Eric Snow's project @ericsnowcurrently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner @bmwiedemann @the-knights-who-say-ni @bedevere-bot