bpo-34403: Skip test_utf8_mode.test_cmd_line() on HP-UX #8966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip this test because it requires a single-byte default locale encoding like ASCII or ISO-8859-1 to properly work with surrogate escapes. Just like CP1252 Roman 8 includes Unicode characters which are encoded in multiple bytes. The final comparison in this test does not handle that. Disable it because assumptions aren't met. Patch by Michael Osipov.
Member
|
I wrote PR #8967 which should fix the test for HP-UX instead of skipping the test. |
Contributor
Author
|
Does not pass. See issue comment. |
Contributor
Author
|
Since @vstinner committed a decent fix, this can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip this test because it requires a single-byte default locale encoding like
ASCII or ISO-8859-1 to properly work with surrogate escapes. Just like CP1252
Roman 8 includes Unicode characters which are encoded in multiple bytes.
The final comparison in this test does not handle that. Disable it because
assumptions aren't met.
Patch by Michael Osipov.
https://bugs.python.org/issue34403