Skip to content

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Jul 11, 2018

In practice, err_ret->text is always replaced later: setting
err_ret->text was useless, removed the code.

https://bugs.python.org/issue34084

In practice, err_ret->text is always replaced later: setting
err_ret->text was useless, removed the code.
@vstinner
Copy link
Member Author

Ah, @serhiy-storchaka proposed a different change: PR #8262.

@vstinner
Copy link
Member Author

I leave @serhiy-storchaka taking care of fixing https://bugs.python.org/issue34084 since he has a different PR to do more or less the same thing.

@vstinner vstinner closed this Jul 16, 2018
@vstinner vstinner deleted the flufl_deadcode branch July 16, 2018 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants