bpo-32980 Remove dead code in _Py_InitializeCore()#5953
Closed
ApproximateIdentity wants to merge 1 commit intopython:masterfrom
Closed
bpo-32980 Remove dead code in _Py_InitializeCore()#5953ApproximateIdentity wants to merge 1 commit intopython:masterfrom
ApproximateIdentity wants to merge 1 commit intopython:masterfrom
Conversation
Contributor
|
Thanks for the patch. We should delete |
Contributor
|
@benjaminp For now, I closed the entire issue based on avoidance of churn in the exported C API (https://bugs.python.org/issue32980#msg313130), but I'd also be happy to amend that to just dropping the nominally private |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove some unneeded function calls. See https://bugs.python.org/issue32980 and https://mail.python.org/pipermail/python-list/2018-March/731389.html for more details.
Cheers,
Thomas
https://bugs.python.org/issue32980