Skip to content

[3.7] bpo-21060: Improve error message for "setup.py upload" without dist files (GH-5726) #5746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
miss-islington merged 1 commit into from
Feb 19, 2018
Merged

[3.7] bpo-21060: Improve error message for "setup.py upload" without dist files (GH-5726) #5746

miss-islington merged 1 commit into from
Feb 19, 2018

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Feb 18, 2018 •
edited by bedevere-bot
Loading

merwok
merwok previously approved these changes Feb 18, 2018
View reviewed changes
@Mariatta Mariatta mentioned this pull request Feb 18, 2018
Closed
@Mariatta Mariatta mentioned this pull request Feb 19, 2018
Closed
@Mariatta
Copy link
Member

Mariatta commented Feb 19, 2018

There's 500 error in bedevere so the issue number check for this PR did not complete.
I opened this ticket: python/bedevere#97

@Mariatta
Copy link
Member

Mariatta commented Feb 19, 2018

I think this should be merged manually so we can fix the commit message.
@merwok I'll dismiss your approval, hope that's ok.

@Mariatta
Copy link
Member

Mariatta commented Feb 19, 2018

Hmm nope, I can't unapprove the PR, so hmm...

Mariatta
Mariatta reviewed Feb 19, 2018
View reviewed changes
Copy link
Member

@Mariatta Mariatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving a comment, will this un-approve the PR?

Mariatta
Mariatta previously requested changes Feb 19, 2018
View reviewed changes
Copy link
Member

@Mariatta Mariatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be merged manually.

@bedevere-bot
Copy link

bedevere-bot commented Feb 19, 2018

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@Mariatta Mariatta dismissed stale reviews from merwok and themself February 19, 2018 03:49

Trying to avoid the auto-merge. Sorry.

@Mariatta Mariatta changed the title [3.7] Improve error message for "setup.py upload" without dist files (GH-21060) [3.7] Improve error message for "setup.py upload" without dist files (GH-5726) Feb 19, 2018
@bedevere-bot bedevere-bot mentioned this pull request Feb 19, 2018
Merged
@miss-islington
Copy link
Contributor Author

miss-islington commented Feb 19, 2018

@merwok: Backport status check is done, and it's a failure ❌ .

@Mariatta Mariatta changed the title [3.7] Improve error message for "setup.py upload" without dist files (GH-5726) [3.7] bpo-20160: Improve error message for "setup.py upload" without dist files (GH-5726) Feb 19, 2018
@miss-islington
Copy link
Contributor Author

miss-islington commented Feb 19, 2018

@merwok: Backport status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

miss-islington commented Feb 19, 2018

@merwok: Backport status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 2072c80 into python:3.7 Feb 19, 2018
@miss-islington
Copy link
Contributor Author

miss-islington commented Feb 19, 2018

Thanks!

@miss-islington miss-islington deleted the backport-08a6926-3.7 branch February 19, 2018 03:57
@Mariatta
Copy link
Member

Mariatta commented Feb 19, 2018

😥 Oh no the auto merge happened anyways....

@merwok
Copy link
Member

merwok commented Feb 19, 2018

Oops missed the messages here. Auto-merge is okay? The patch is correct and the ticket was linked.

@merwok
Copy link
Member

merwok commented Feb 19, 2018

Oh dear I linked to the wrong ticket

@merwok merwok changed the title [3.7] bpo-20160: Improve error message for "setup.py upload" without dist files (GH-5726) [3.7] bpo-21060: Improve error message for "setup.py upload" without dist files (GH-5726) Feb 19, 2018
@Mariatta Mariatta mentioned this pull request Feb 20, 2018
Closed
ambv pushed a commit that referenced this pull request Aug 6, 2022
@miss-islington @Yaminyam
�gh-95376: Add test for names containing null (GH-GH-5394) (#GH-5746)
6dffb5f 
Co-authored-by: Erlend Egeberg Aasland <[email protected]>
(cherry picked from commit a17cd47)

Co-authored-by: Sion Kang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merwok merwok merwok left review comments

@Mariatta Mariatta Mariatta left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miss-islington @Mariatta @bedevere-bot @merwok @the-knights-who-say-ni