[3.7] bpo-32303 - Consistency fixes for namespace loaders (GH-5481)#5498
Closed
miss-islington wants to merge 1 commit intopython:3.7from
Closed
[3.7] bpo-32303 - Consistency fixes for namespace loaders (GH-5481)#5498miss-islington wants to merge 1 commit intopython:3.7from
miss-islington wants to merge 1 commit intopython:3.7from
Conversation
* Make sure ``__spec__.loader`` matches ``__loader__`` for namespace packages. * Make sure ``__spec__.origin` matches ``__file__`` for namespace packages. https://bugs.python.org/issue32303 https://bugs.python.org/issue32305 (cherry picked from commit bbbcf86) Co-authored-by: Barry Warsaw <[email protected]>
Contributor
Author
|
@warsaw: Backport status check is done, and it's a success ✅ . |
1 similar comment
Contributor
Author
|
@warsaw: Backport status check is done, and it's a success ✅ . |
Member
|
Closing in favor of #5503 - @brettcannon and I agree that because of the changes to importlib.h and importlib_external.h, it's safer to do a manual rebuild and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__spec__.loadermatches__loader__for namespace packages.__spec__.origin` matchesfile`` for namespace packages.https://bugs.python.org/issue32303
https://bugs.python.org/issue32305
(cherry picked from commit bbbcf86)
Co-authored-by: Barry Warsaw [email protected]
https://bugs.python.org/issue32303