Skip to content

Conversation

@pganssle
Copy link
Member

@pganssle pganssle commented Jan 5, 2018

Noticed some minor grammar errors in the unittest.mock.seal documentation added in #1923.

CC: @mariocj89 @vstinner

https://bugs.python.org/issue30541

No news needed since it's a documentation fix for an unreleased function.

@pganssle pganssle changed the title Cleanup grammar in unittest.mock.seal documentation [bpo-30541] Cleanup grammar in unittest.mock.seal documentation Jan 5, 2018
@miss-islington
Copy link
Contributor

Thanks @pganssle for the PR, and @asvetlov for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @pganssle and @asvetlov, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 85ac726a40707ae68a23d568c322868e353217ce 3.6

@asvetlov
Copy link
Contributor

asvetlov commented Jan 6, 2018

Let's not backport to 3.6 -- the change is small, don't worth manual cherry-picking.

@pganssle pganssle deleted the grammar_tweak_seal branch October 25, 2018 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants