bpo-32377: improve __del__ docs and fix mention about resurrection #4927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitrou
changed the title
pitrou
changed the title
| It is possible (though not recommended!) for the :meth:`__del__` method | ||
| to postpone destruction of the instance by creating a new reference to | ||
| it. This is called object *resurrection*. It is implementation-dependent | ||
| whether :meth:`__del__` is called a second time when a resurrected object |
There was a problem hiding this comment.
Could the phrase starting with "It is implementation-dependent..." possibly be reworded to more directly reflect common implementations and the caveat this brings?
Something like:
":meth:__del__ is generally only called once for a resurrected object (though this is implementation-dependent), so it may only be possible to resurrect an instance once using :meth:__del__."
Member
Author
There was a problem hiding this comment.
Fair enough, I've added a mention that CPython only calls __del__ once.
Contributor
|
Thanks @pitrou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 19, 2017
…ythonGH-4927) * Fix pythonGH-32377: improve __del__ docs and fix mention about resurrection * Mention that CPython only calls __del__ once. (cherry picked from commit 4b96593)
|
GH-4929 is a backport of this pull request to the 3.6 branch. |
pitrou
pushed a commit
that referenced
this pull request
Dec 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue32377