Skip to content

Conversation

@native-api
Copy link
Contributor

@native-api native-api commented Nov 16, 2017

Specify how to build installer in Windows
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@Mariatta
Copy link
Member

Thanks for the PR. I noticed the PR against the master branch is not yet merged.
Typically you should first create a PR to the master branch. Once that has been approved and merged, then we can backport the changes to the other branches.

@native-api
Copy link
Contributor Author

In some previous branches, more and/or differently phrased text needs to be added. So I made the backports by hand and submitted them as different PRs.

@zooba zooba merged commit c696119 into python:3.6 Nov 17, 2017
@zooba
Copy link
Member

zooba commented Nov 17, 2017

This added more changes from the automatic backport, so I merged it as well. It's all in - thanks, @native-api!

@native-api native-api deleted the build_instructions_3.6 branch November 17, 2017 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants