Skip to content

gh-76183: Fix legacy locale coercion tests on platforms that already have a default C.UTF-8 locale #4361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
embray wants to merge 1 commit into from
Closed

gh-76183: Fix legacy locale coercion tests on platforms that already have a default C.UTF-8 locale #4361

embray wants to merge 1 commit into from

Conversation

@embray
Copy link
Contributor

@embray embray commented Nov 10, 2017 •
edited by erlend-aasland
Loading

Fix legacy locale coercion tests on platforms that already have a default C.UTF-8 locale

ncoghlan
ncoghlan reviewed Nov 10, 2017
View reviewed changes
Lib/test/test_c_locale_coercion.py Outdated
Copy link
Contributor

@ncoghlan ncoghlan Nov 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in the comment: enivornment -> environment

Copy link
Contributor Author

@embray embray Nov 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, I'll just fix that and squash...

@embray embray force-pushed the cygwin/test-c-locale-coercion branch from 91f7983 to 5f6d3a0 Compare November 10, 2017 11:17
xdegaye
xdegaye suggested changes Nov 11, 2017
View reviewed changes
Lib/test/test_c_locale_coercion.py
result.fail(py_cmd)

DEFAULT_LC_CTYPE = result.out.decode("ascii").strip().upper()

Copy link
Contributor

@xdegaye xdegaye Nov 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try setting C_LOCALE_STREAM_ENCODING to "utf-8" instead ?

Lib/test/test_c_locale_coercion.py
# See https://bugs.python.org/issue30672 for discussion
if locale_to_set == "POSIX":
continue
elif locale_to_set == "" and DEFAULT_LC_CTYPE == "C.UTF-8":
Copy link
Contributor

@xdegaye xdegaye Nov 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition is too restrictive:

  • When locale_to_set is "" and a locale envt variable exists in extra_vars with a non empty string (for example in test_LC_ALL_set_to_C), the subtest may be run.
  • It seems that when C_LOCALE_STREAM_ENCODING is set to "utf-8" and coerce_c_localecoerce_c_locale is not "warn" then the test should pass.

@bedevere-bot
Copy link

bedevere-bot commented Nov 11, 2017

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@embray embray mentioned this pull request Nov 13, 2017
Merged
@embray embray mentioned this pull request Apr 10, 2022
Closed
@github-actions
Copy link

github-actions bot commented Aug 13, 2022

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Aug 13, 2022
@erlend-aasland
Copy link
Contributor

erlend-aasland commented Jan 23, 2023

@embray: are you planning on following up this PR/issue?

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Jan 24, 2023
@github-actions
Copy link

github-actions bot commented Feb 23, 2023

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Feb 23, 2023
@erlend-aasland erlend-aasland changed the title bpo-32002 Fix legacy locale coercion tests on platforms that already have a default C.UTF-8 locale gh-76183: Fix legacy locale coercion tests on platforms that already have a default C.UTF-8 locale Feb 23, 2023
@erlend-aasland erlend-aasland added the pending The issue will be closed if no feedback is provided label Feb 23, 2023
@erlend-aasland
Copy link
Contributor

erlend-aasland commented Feb 23, 2023

After one month, still no response. Suggesting to close this PR and the related issue (Cygwin is not supported).

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Feb 24, 2023
@arhadthedev
Copy link
Member

arhadthedev commented Mar 4, 2023 •
edited
Loading

@embray Could you address the reviews please?

@github-actions
Copy link

github-actions bot commented Apr 4, 2023

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Apr 4, 2023
@erlend-aasland erlend-aasland removed the pending The issue will be closed if no feedback is provided label Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncoghlan ncoghlan ncoghlan left review comments

+1 more reviewer

@xdegaye xdegaye xdegaye requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting changes stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@embray @bedevere-bot @erlend-aasland @arhadthedev @ncoghlan @xdegaye @the-knights-who-say-ni @ezio-melotti