bpo-22257: Mention startup refactoring in What's New #4286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While technically a purely internal change, bpo-31845 was a fairly significant externally visible bug caused by these changes (environment variable based configuration was being ignored due to a change in the relative order of reading the environment and reading command line settings, and the test suite was only testing the command line options) Hence this note to essentially say "If you see odd startup problems in 3.7 that you've never seen in previous releases, it's probably our fault, so let us know, and we'll fix it".
Contributor
Author
|
@ericsnowcurrently The review request was mainly to make sure you saw that I'd added this note, but also feel free to amend it if you think the wording could be improved :) |
embray
pushed a commit
to embray/cpython
that referenced
this pull request
Nov 9, 2017
While technically a purely internal change, bpo-31845 was a fairly significant externally visible bug caused by these changes (environment variable based configuration was being ignored due to a change in the relative order of reading the environment and reading command line settings, and the test suite was only testing the command line options) Hence this note to essentially say "If you see odd startup problems in 3.7 that you've never seen in previous releases, it's probably our fault, so let us know, and we'll fix it".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While technically a purely internal change, bpo-31845 was
a fairly significant externally visible bug caused by
these changes (environment variable based configuration
was being ignored due to a change in the relative order
of reading the environment and reading command line settings,
and the test suite was only testing the command line options)
Hence this note to essentially say "If you see odd startup
problems in 3.7 that you've never seen in previous releases,
it's probably our fault, so let us know, and we'll fix it".
https://bugs.python.org/issue22257