[2.7] bpo-30806: Fix netrc.__repr__() format (GH-2491)#4276
Merged
methane merged 3 commits intopython:2.7from Dec 10, 2017
Merged
[2.7] bpo-30806: Fix netrc.__repr__() format (GH-2491)#4276methane merged 3 commits intopython:2.7from
methane merged 3 commits intopython:2.7from
Conversation
netrc file format doesn't support quotes and escapes. See https://linux.die.net/man/5/netrc
sloria
force-pushed
the
backport-bpo-30806-fix
branch
from
8e6e688 to
247057d
Compare
methane
changed the title
Member
|
test is failing on Windows. |
Author
Member
|
Yes, that's why I don't want to backport it by myself. Backporting to 2.7 requires significant efforts. I don't have time and motivation about thinking about how to backport it. I'm very busy in these |
methane
reviewed
Nov 7, 2017
Lib/test/test_netrc.py
Outdated
Member
There was a problem hiding this comment.
Maybe, reverting this change may fix the error.
Member
There was a problem hiding this comment.
Don't forget to remove import tempfile when reverting this.
Author
|
@methane I understand. No worries; I'm also busier than usual these days, but I'll take a look at those Windows tests when I have time. |
Also, make the tests work in 2.7
sloria
force-pushed
the
backport-bpo-30806-fix
branch
from
247057d to
72d9096
Compare
sloria
force-pushed
the
backport-bpo-30806-fix
branch
from
72d9096 to
40b0005
Compare
Author
|
@methane Thanks for the tip with the tests. All green now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the fix for https://bugs.python.org/issue30806 and updates the syntax for Python 2.7 compatibility.
https://bugs.python.org/issue30806