Skip to content

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Oct 17, 2017

Document the new PYTHONSHOWREFCOUNT and
PYTHONSHOWALLOCCOUNT environment variables.

https://bugs.python.org/issue31733

bpo-31733, bpo-31692: Document the new PYTHONSHOWREFCOUNT and
PYTHONSHOWALLOCCOUNT environment variables.
@vstinner vstinner changed the title [2.7] Document 2 new env vars in What's New in Python 2.7 [2.7] bpo-31733, bpo-31692: Document 2 new env vars in What's New in Python 2.7 Oct 17, 2017
(Contributed by Victor Stinner; :issue:`31733`.)

When Python is compiled with ``COUNT_ALLOC`` defined, allocations counts are no
more dumped by default anymore: the :envvar:`PYTHONSHOWALLOCCOUNT` environment
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: "no more dumped" isn't grammatically correct.

Perhaps change:

allocations counts are no more dumped by default anymore

to:

allocation counts are no longer dumped by default

Cheers

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry. It's not the first time that someone reports me this grammar mistake, and I continue to make it... Thank you for your review. Since english is not my first language, I appreciate such feedback ;-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to apologize. Thanks for all you do!


When Python is compiled with ``COUNT_ALLOC`` defined, allocations counts are no
more dumped by default anymore: the :envvar:`PYTHONSHOWALLOCCOUNT` environment
variable now must also be set. Moreover, allocations counts are now dumped into
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/now must/must now

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


When Python is compiled with ``COUNT_ALLOC`` defined, allocations counts are no
more dumped by default anymore: the :envvar:`PYTHONSHOWALLOCCOUNT` environment
variable now must also be set. Moreover, allocations counts are now dumped into
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/allocations counts/allocation counts

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Member Author

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dianaclarke for your review. Would you mind to review it again?

(Contributed by Victor Stinner; :issue:`31733`.)

When Python is compiled with ``COUNT_ALLOC`` defined, allocations counts are no
more dumped by default anymore: the :envvar:`PYTHONSHOWALLOCCOUNT` environment
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry. It's not the first time that someone reports me this grammar mistake, and I continue to make it... Thank you for your review. Since english is not my first language, I appreciate such feedback ;-)


When Python is compiled with ``COUNT_ALLOC`` defined, allocations counts are no
more dumped by default anymore: the :envvar:`PYTHONSHOWALLOCCOUNT` environment
variable now must also be set. Moreover, allocations counts are now dumped into
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


When Python is compiled with ``COUNT_ALLOC`` defined, allocations counts are no
more dumped by default anymore: the :envvar:`PYTHONSHOWALLOCCOUNT` environment
variable now must also be set. Moreover, allocations counts are now dumped into
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Member

@dianaclarke dianaclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@vstinner vstinner merged commit 355393e into python:2.7 Oct 17, 2017
@vstinner vstinner deleted the debug_news27 branch October 17, 2017 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants