-
-
Notifications
You must be signed in to change notification settings - Fork 33.9k
[2.7] bpo-31733, bpo-31692: Document 2 new env vars in What's New in Python 2.7 #4019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Doc/whatsnew/2.7.rst
Outdated
| (Contributed by Victor Stinner; :issue:`31733`.) | ||
|
|
||
| When Python is compiled with ``COUNT_ALLOC`` defined, allocations counts are no | ||
| more dumped by default anymore: the :envvar:`PYTHONSHOWALLOCCOUNT` environment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: "no more dumped" isn't grammatically correct.
Perhaps change:
allocations counts are no more dumped by default anymore
to:
allocation counts are no longer dumped by default
Cheers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry. It's not the first time that someone reports me this grammar mistake, and I continue to make it... Thank you for your review. Since english is not my first language, I appreciate such feedback ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to apologize. Thanks for all you do!
Doc/whatsnew/2.7.rst
Outdated
|
|
||
| When Python is compiled with ``COUNT_ALLOC`` defined, allocations counts are no | ||
| more dumped by default anymore: the :envvar:`PYTHONSHOWALLOCCOUNT` environment | ||
| variable now must also be set. Moreover, allocations counts are now dumped into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/now must/must now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Doc/whatsnew/2.7.rst
Outdated
|
|
||
| When Python is compiled with ``COUNT_ALLOC`` defined, allocations counts are no | ||
| more dumped by default anymore: the :envvar:`PYTHONSHOWALLOCCOUNT` environment | ||
| variable now must also be set. Moreover, allocations counts are now dumped into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/allocations counts/allocation counts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
vstinner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @dianaclarke for your review. Would you mind to review it again?
Doc/whatsnew/2.7.rst
Outdated
| (Contributed by Victor Stinner; :issue:`31733`.) | ||
|
|
||
| When Python is compiled with ``COUNT_ALLOC`` defined, allocations counts are no | ||
| more dumped by default anymore: the :envvar:`PYTHONSHOWALLOCCOUNT` environment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry. It's not the first time that someone reports me this grammar mistake, and I continue to make it... Thank you for your review. Since english is not my first language, I appreciate such feedback ;-)
Doc/whatsnew/2.7.rst
Outdated
|
|
||
| When Python is compiled with ``COUNT_ALLOC`` defined, allocations counts are no | ||
| more dumped by default anymore: the :envvar:`PYTHONSHOWALLOCCOUNT` environment | ||
| variable now must also be set. Moreover, allocations counts are now dumped into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Doc/whatsnew/2.7.rst
Outdated
|
|
||
| When Python is compiled with ``COUNT_ALLOC`` defined, allocations counts are no | ||
| more dumped by default anymore: the :envvar:`PYTHONSHOWALLOCCOUNT` environment | ||
| variable now must also be set. Moreover, allocations counts are now dumped into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
dianaclarke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Document the new PYTHONSHOWREFCOUNT and
PYTHONSHOWALLOCCOUNT environment variables.
https://bugs.python.org/issue31733