Skip to content

[2.7] bpo-31455: avoid calling "PyObject_GetAttrString()" with a live exception set#3992

Merged
serhiy-storchaka merged 1 commit intopython:2.7from
scoder:bpo_31455_27
Mar 24, 2018
Merged

[2.7] bpo-31455: avoid calling "PyObject_GetAttrString()" with a live exception set#3992
serhiy-storchaka merged 1 commit intopython:2.7from
scoder:bpo_31455_27

Conversation

@scoder
Copy link
Copy Markdown
Contributor

@scoder scoder commented Oct 14, 2017

@serhiy-storchaka
Copy link
Copy Markdown
Member

Do you mind to fix tests failure @scoder?

@serhiy-storchaka serhiy-storchaka changed the title bpo-31455: avoid calling "PyObject_GetAttrString()" with a live exception set [2.7] bpo-31455: avoid calling "PyObject_GetAttrString()" with a live exception set Feb 26, 2018
@scoder scoder closed this Feb 26, 2018
@scoder scoder reopened this Feb 26, 2018
…executing user code) with a live exception set.

Backport to Py2.7
@scoder
Copy link
Copy Markdown
Contributor Author

scoder commented Feb 26, 2018

Updated and rebased on latest 2.7 branch.
Took me a while to figure out what was wrong. In fact, pyET behaves entirely differently here and only looks up the methods at need, thus actually requiring them to be always available. Since that renders the test useless, I've disabled it for pyET and only left it in for cET.

@serhiy-storchaka serhiy-storchaka merged commit 0694b6a into python:2.7 Mar 24, 2018
@serhiy-storchaka
Copy link
Copy Markdown
Member

Thanks @scoder!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants