Skip to content

[3.8] bpo-31508: Remove support of arguments in tkinter.ttk.Treeview.selection.#3651

Merged
serhiy-storchaka merged 5 commits intopython:masterfrom
serhiy-storchaka:treeview-selection
Feb 1, 2018
Merged

[3.8] bpo-31508: Remove support of arguments in tkinter.ttk.Treeview.selection.#3651
serhiy-storchaka merged 5 commits intopython:masterfrom
serhiy-storchaka:treeview-selection

Conversation

@serhiy-storchaka
Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka commented Sep 19, 2017

Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

  • You fixed the warn for which I complained
  • You documented the change and explained how to upgrade the code
  • You wrote a NEWS entry

Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM.

It's up to you to apply this one or PR #3667.

@terryjreedy
Copy link
Copy Markdown
Member

I think you should apply #3667 now, for 3.7, and this after 3.7 is branched off, for 3.8.

@serhiy-storchaka serhiy-storchaka changed the title bpo-31508: Remove support of arguments in tkinter.ttk.Treeview.selection. [3.8] bpo-31508: Remove support of arguments in tkinter.ttk.Treeview.selection. Sep 24, 2017
@serhiy-storchaka serhiy-storchaka merged commit 97f1ca1 into python:master Feb 1, 2018
@serhiy-storchaka serhiy-storchaka deleted the treeview-selection branch February 1, 2018 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-feature A feature request or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants