Skip to content

[3.6] bpo-31455: Fix an assertion failure in ElementTree.XMLParser(). (GH-3545)#3585

Merged
serhiy-storchaka merged 1 commit intopython:3.6from
miss-islington:backport-c8d8e15-3.6
Sep 14, 2017
Merged

[3.6] bpo-31455: Fix an assertion failure in ElementTree.XMLParser(). (GH-3545)#3585
serhiy-storchaka merged 1 commit intopython:3.6from
miss-islington:backport-c8d8e15-3.6

Conversation

@miss-islington
Copy link
Copy Markdown
Contributor

@miss-islington miss-islington commented Sep 14, 2017

  • Avoid calling "PyObject_GetAttrString()" (and potentially executing user code) with a live exception set.

  • Ignore only AttributeError on attribute lookups in ElementTree.XMLParser() and propagate all other exceptions.
    (cherry picked from commit c8d8e15)

https://bugs.python.org/issue31455

…pythonGH-3545)

* Avoid calling "PyObject_GetAttrString()" (and potentially executing user code) with a live exception set.

* Ignore only AttributeError on attribute lookups in ElementTree.XMLParser() and propagate all other exceptions.
(cherry picked from commit c8d8e15)
@the-knights-who-say-ni
Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@miss-islington
Copy link
Copy Markdown
Contributor Author

Thanks, @serhiy-storchaka!

@miss-islington miss-islington deleted the backport-c8d8e15-3.6 branch September 14, 2017 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants