bpo-47098: Replace Keccak Code Package with tiny_sha3 (GH-32060)#32060
Merged
tiran merged 4 commits intopython:mainfrom Mar 26, 2022
Merged
bpo-47098: Replace Keccak Code Package with tiny_sha3 (GH-32060)#32060tiran merged 4 commits intopython:mainfrom
tiran merged 4 commits intopython:mainfrom
Conversation
tiran
added
DO-NOT-MERGE
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @tiran for commit 62f315c3be2ac37cee8df06d03b979fcda41b219 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot
added
awaiting core review
and removed
🔨 test-with-buildbots
gpshead
reviewed
Mar 22, 2022
Member
gpshead
left a comment
gpshead
left a comment
There was a problem hiding this comment.
hah, that one is amazingly small. nice.
tiran
changed the title
Member
Author
Wait until you size the binary size! It's 380kB -> 69 kB (stripped 90kB -> 25kB). |
tiran
added
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @tiran for commit e8fd0118edcd9f53686d63e417f3799620a29bdd 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
Member
Author
|
@gpshead please take another look |
gpshead
reviewed
Mar 26, 2022
Misc/NEWS.d/next/Library/2022-03-23-10-07-41.bpo-47098.7AN_qp.rst
Outdated
Show resolved
Hide resolved
gpshead
approved these changes
Mar 26, 2022
tiran
changed the title
This was referenced Mar 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue47098