bpo-46329: Avoid PUSH_NULL when followed by LOAD_GLOBAL#31933
Merged
markshannon merged 1 commit intopython:mainfrom Mar 17, 2022
Merged
bpo-46329: Avoid PUSH_NULL when followed by LOAD_GLOBAL#31933markshannon merged 1 commit intopython:mainfrom
PUSH_NULL when followed by LOAD_GLOBAL#31933markshannon merged 1 commit intopython:mainfrom
Conversation
…h an additional NULL.
markshannon
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @markshannon for commit 198517e 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
Member
Author
|
Buildbot failures seem unrelated to this PR: 2 pre-existing failures and one asyncio timeout. |
Contributor
|
I may be missing something but shouldn't the computation for the stack effect of LOAD_GLOBAL be also adjusted since it can now push 2 elements on the stack ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses the low bit of
LOAD_GLOBAL's oparg to indicate whether it should push a NULL first.now compiles to
This reduces the total number of VM instructions executed by ~2%.
The benchmark results show an unlikely 3% speedup, probably just one of those random build variations.
https://bugs.python.org/issue46329