bpo-46932: Update bundled libexpat to 2.4.7#31736
Merged
zooba merged 2 commits intopython:mainfrom Mar 7, 2022
Merged
Conversation
hartwork
suggested changes
Mar 7, 2022
Contributor
There was a problem hiding this comment.
The pyexpatns.h part should probably not be dropped, please see the comment below.
The PR is likely good once it passes this Dockerfile of mine (and it does not, yet):
# Copyright (c) 2022 Sebastian Pipping <[email protected]>
# Licensed under the Apache License version 2.0
FROM alpine
RUN apk add --update \
diffutils \
git \
sed \
&& \
git clone --depth 1 https://github.com/python/cpython cpython-main \
&& \
( cd cpython-main && git rev-parse HEAD ) \
&& \
git clone --depth 1 --branch bpo-46932 https://github.com/zooba/cpython zooba-bpo-46932 \
&& \
( cd zooba-bpo-46932 && git rev-parse HEAD ) \
&& \
git config --global advice.detachedHead false \
&& \
git clone --depth 1 --branch R_2_4_6 https://github.com/libexpat/libexpat libexpat_2_4_6 \
&& \
git clone --depth 1 --branch R_2_4_7 https://github.com/libexpat/libexpat libexpat_2_4_7 \
&& \
diff -r -u libexpat_2_4_6/expat/lib/ cpython-main/Modules/expat/ | tee 2-4-6.diff \
&& \
diff -r -u libexpat_2_4_7/expat/lib/ zooba-bpo-46932/Modules/expat/ | tee 2-4-7.diff \
&& \
sed -e '/^Only in /d' -e '/^\(+++\|---\) /d' -e '/^diff /d' -i 2-4-6.diff 2-4-7.diff \
&& \
diff -u 2-4-6.diff 2-4-7.diff \
&& \
echo 'Diff is good.'
hartwork
approved these changes
Mar 7, 2022
Contributor
|
Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8, 3.9, 3.10. |
|
GH-31738 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 7, 2022
(cherry picked from commit 176835c) Co-authored-by: Steve Dower <[email protected]>
|
GH-31739 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 7, 2022
(cherry picked from commit 176835c) Co-authored-by: Steve Dower <[email protected]>
|
GH-31740 is a backport of this pull request to the 3.8 branch. |
|
GH-31741 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 7, 2022
(cherry picked from commit 176835c) Co-authored-by: Steve Dower <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 7, 2022
(cherry picked from commit 176835c) Co-authored-by: Steve Dower <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Mar 7, 2022
(cherry picked from commit 176835c) Co-authored-by: Steve Dower <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Mar 7, 2022
(cherry picked from commit 176835c) Co-authored-by: Steve Dower <[email protected]>
ned-deily
pushed a commit
that referenced
this pull request
Mar 7, 2022
(cherry picked from commit 176835c) Co-authored-by: Steve Dower <[email protected]>
ambv
pushed a commit
that referenced
this pull request
Mar 8, 2022
(cherry picked from commit 176835c) Co-authored-by: Steve Dower <[email protected]>
hello-adam
pushed a commit
to hello-adam/cpython
that referenced
this pull request
Jun 2, 2022
(cherry picked from commit 176835c) Co-authored-by: Steve Dower <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue46932