bpo-46852: Remove the float.__set_format__() method#31585
bpo-46852: Remove the float.__set_format__() method#31585vstinner merged 1 commit intopython:mainfrom vstinner:remove_float_setformat
Conversation
Remove the undocumented private float.__set_format__() method, previously known as float.__set_format__() in Python 3.7. Its docstring said: "You probably don't want to use this function. It exists mainly to be used in Python's test suite."
|
@mdickinson: Would you mind to review this change? |
Happy to do so, if you'll allow me time. :-) But it appears I'm too late. |
| float.__setformat__('double', self.save_formats['double']) | ||
| float.__setformat__('float', self.save_formats['float']) | ||
|
|
||
| def test_getformat(self): |
There was a problem hiding this comment.
Aren't these tests still relevant?
mdickinson
left a comment
mdickinson
left a comment
There was a problem hiding this comment.
LGTM, but I think test_getformat should be kept.
Remove the undocumented private float.__set_format__() method, previously known as float.__set_format__() in Python 3.7. Its docstring said: "You probably don't want to use this function. It exists mainly to be used in Python's test suite."
Sorry, sometimes I can be too impatient. I took your comment on the issue as an approval of the overall removal.
... But I didn't review carefully removed tests! I saw I wrote #31601 to add getformat tests removed by mistake. Thanks for the review. Sorry again for not waiting for your review. |
4 participants
Remove the undocumented private float.set_format() method,
previously known as float.set_format() in Python 3.7. Its
docstring said: "You probably don't want to use this function. It
exists mainly to be used in Python's test suite."
https://bugs.python.org/issue46852