Skip to content

bpo-46709: fix race conditions in unittest/test_brake#31273

Closed
sobolevn wants to merge 1 commit intopython:mainfrom
sobolevn:issue-46709
Closed

bpo-46709: fix race conditions in unittest/test_brake#31273
sobolevn wants to merge 1 commit intopython:mainfrom
sobolevn:issue-46709

Conversation

@sobolevn
Copy link
Copy Markdown
Member

@sobolevn sobolevn commented Feb 11, 2022 •
edited by bedevere-bot
Loading

Affected tests:

  • ./python.exe -m test -m unittest.test.test_break.TestBreakDefaultIntHandler.testInterruptCaught test_unittest -F
  • ./python.exe -m test -m unittest.test.test_break.TestBreakDefaultIntHandler.testSecondInterrupt test_unittest -F
  • ./python.exe -m test -m unittest.test.test_break.TestBreakDefaultIntHandler.testTwoResults test_unittest -F
  • ./python.exe -m test -m unittest.test.test_break.TestBreakDefaultIntHandler.testHandlerReplacedButCalled test_unittest -F

Before:
Снимок экрана 2022-02-11 в 12 05 51

After (manually terminated):
Снимок экрана 2022-02-11 в 12 05 35

I simply re-arranged assert statements to make this pass: https://docs.python.org/3/library/signal.html#execution-of-python-signal-handlers

Maybe there's something more clever to do instead? 🙂

https://bugs.python.org/issue46709

@bedevere-bot bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Feb 11, 2022
@sobolevn sobolevn requested a review from vstinner February 11, 2022 09:09
@kumaraditya303
Copy link
Copy Markdown
Contributor

kumaraditya303 commented Feb 11, 2022

The tests were passing before so I guess it might have be caused due to a missing eval breaker in ceval.c in specialised bytecode to check for signals. Perhaps you can git bisect to see if this is the case?

@sobolevn
Copy link
Copy Markdown
Member Author

sobolevn commented Feb 11, 2022

The tests were passing before

They are still passing. Take a look:

Снимок экрана 2022-02-11 в 13 12 24

But, they are flaky.

it might have be caused due to a missing eval breaker in ceval.c in specialised bytecode to check for signals. Perhaps you can git bisect to see if this is the case?

I will take a look if there were recent changes. Thanks for the idea! 👍

@sobolevn
Copy link
Copy Markdown
Member Author

sobolevn commented Feb 11, 2022 •
edited by bedevere-bot
Loading

git bisect shows that this is the first failing commit: 3163e68

» git bisect good
3163e68c342434db37c69669017f96a4bb2d5f13 is the first bad commit
commit 3163e68c342434db37c69669017f96a4bb2d5f13
Author: Ken Jin <[email protected]>
Date:   Wed Oct 20 07:16:36 2021 +0800

    [bpo-44525](https://bugs.python.org/issue44525): Specialize ``CALL_FUNCTION`` for C function calls (GH-26934)

 Include/internal/pycore_code.h                     |   1 +
 Include/opcode.h                                   |  51 +++----
 Lib/opcode.py                                      |   5 +
 .../2021-06-28-22-23-59.[bpo-44525](https://bugs.python.org/issue44525).sSvUKG.rst       |  10 ++
 Python/ceval.c                                     | 147 +++++++++++++++++++++
 Python/opcode_targets.h                            |  54 ++++----
 Python/specialize.c                                | 147 +++++++++++++++++++++
 7 files changed, 365 insertions(+), 50 deletions(-)
 create mode 100644 Misc/NEWS.d/next/Core and Builtins/2021-06-28-22-23-59.[bpo-44525](https://bugs.python.org/issue44525).sSvUKG.rst

CC @Fidget-Spinner

@sobolevn
Copy link
Copy Markdown
Member Author

sobolevn commented Feb 11, 2022

I think the proper fix would be adding CHECK_EVAL_BREAKER(); into specialized CALL_NO_KW_ opcodes. Testing this out 🤔

@sobolevn
Copy link
Copy Markdown
Member Author

sobolevn commented Feb 11, 2022

Duplicate of https://github.com/python/cpython/pull/30826/files

@sobolevn sobolevn closed this Feb 11, 2022
@sobolevn sobolevn mentioned this pull request Feb 18, 2022
Merged
@Fidget-Spinner Fidget-Spinner mentioned this pull request Sep 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner Awaiting requested review from vstinner

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Labels

awaiting review skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sobolevn @kumaraditya303 @the-knights-who-say-ni @bedevere-bot