[3.8] bpo-46648: Skip test_urllib2.test_issue16464() (GH-31161) #31173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
POST requests to http://www.example.com/ fail randomly. (cherry picked from commit 1578de2) Co-authored-by: Victor Stinner <[email protected]>
Contributor
Author
|
@vstinner: Status check is done, and it's a success ✅ . |
Member
|
@ambv: You may want to get this fix. The 10 Refleaks 3.8 buildbots are failing because of test_urllib2: https://buildbot.python.org/all/#/release_status |
Contributor
Author
|
@vstinner: Status check is done, and it's a success ✅ . |
Member
|
fwiw, a more proper fix to backport is coming in #31186. but it probably doesn't matter which one is chosen for 3.8 as it's not like the code this is testing behavior of could ever change in this branch. |
Member
|
Thanks for the merge @ambv! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POST requests to http://www.example.com/ fail randomly.
(cherry picked from commit 1578de2)
Co-authored-by: Victor Stinner [email protected]
https://bugs.python.org/issue46648