bpo-42926: call compute_code_flags() once and and reuse the value#31116
Closed
iritkatriel wants to merge 1 commit intopython:mainfrom
Closed
bpo-42926: call compute_code_flags() once and and reuse the value#31116iritkatriel wants to merge 1 commit intopython:mainfrom
iritkatriel wants to merge 1 commit intopython:mainfrom
Conversation
iritkatriel
changed the title
Member
Author
|
This will be rolled into the big refactor, no point doing it separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not just about saving a call to compute_code_flags(), it also reduces the reliance on the "struct compiler" pointer in the functions of the assembler stage so it's a small step towards the refactor.
https://bugs.python.org/issue42926