Skip to content

Comments

bpo-45925: Update macOS installer to SQLite 3.37.2#30921

Merged
ned-deily merged 4 commits intopython:mainfrom
kumaraditya303:sqlite
Feb 1, 2022
Merged

bpo-45925: Update macOS installer to SQLite 3.37.2#30921
ned-deily merged 4 commits intopython:mainfrom
kumaraditya303:sqlite

Conversation

@kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Jan 26, 2022 •
edited by bedevere-bot
Loading

@kumaraditya303 kumaraditya303 requested a review from a team as a code owner January 26, 2022 12:02
@kumaraditya303 kumaraditya303 mentioned this pull request Jan 26, 2022
Merged
erlend-aasland
erlend-aasland approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please fix PR title: SQlite => SQLite ;)

@kumaraditya303 kumaraditya303 changed the title bpo-45925: Update macOS installer to SQlite 3.37.2 bpo-45925: Update macOS installer to SQLite 3.37.2 Jan 27, 2022
@ned-deily ned-deily merged commit 0e4bef7 into python:main Feb 1, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Feb 1, 2022

Thanks @kumaraditya303 for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Feb 1, 2022

Sorry, @kumaraditya303 and @ned-deily, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 0e4bef7a7f6f25a6f39755778c73e7026901611f 3.10

@miss-islington
Copy link
Contributor

miss-islington commented Feb 1, 2022

Sorry @kumaraditya303 and @ned-deily, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 0e4bef7a7f6f25a6f39755778c73e7026901611f 3.9

@miss-islington
Copy link
Contributor

miss-islington commented Feb 1, 2022

Thanks @kumaraditya303 for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Feb 1, 2022

Thanks @kumaraditya303 for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Feb 1, 2022

Sorry, @kumaraditya303 and @ned-deily, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 0e4bef7a7f6f25a6f39755778c73e7026901611f 3.9

@miss-islington
Copy link
Contributor

miss-islington commented Feb 1, 2022

Sorry @kumaraditya303 and @ned-deily, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 0e4bef7a7f6f25a6f39755778c73e7026901611f 3.10

@ned-deily
Copy link
Member

ned-deily commented Feb 1, 2022

@AlexWaygood I'm working on the backports.

@AlexWaygood
Copy link
Member

AlexWaygood commented Feb 1, 2022

Yes, sorry, I misread miss-islington's message.

ned-deily pushed a commit to ned-deily/cpython that referenced this pull request Feb 1, 2022
@kumaraditya303 @ned-deily
bpo-45925: Update macOS installer to SQLite 3.37.2 (pythonGH-30921)
e5865af 
Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented Feb 1, 2022

GH-31057 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Feb 1, 2022
ned-deily added a commit that referenced this pull request Feb 1, 2022
@ned-deily @kumaraditya303
bpo-45925: Update macOS installer to SQLite 3.37.2 (GH-30921) (GH-31057)
519eb6a 
Co-authored-by: Kumar Aditya <[email protected]>
Co-authored-by: Erlend Egeberg Aasland <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 1, 2022
@ned-deily @miss-islington
bpo-45925: Update macOS installer to SQLite 3.37.2 (pythonGH-30921) (p…
9dc3239 
…ythonGH-31057)

Co-authored-by: Kumar Aditya <[email protected]>
Co-authored-by: Erlend Egeberg Aasland <[email protected]>
(cherry picked from commit 519eb6a)

Co-authored-by: Ned Deily <[email protected]>
ned-deily pushed a commit that referenced this pull request Feb 1, 2022
@miss-islington @kumaraditya303
bpo-45925: Update macOS installer to SQLite 3.37.2 (GH-30921) (GH-31057…
a22dd00 
…) (GH-31059)

Co-authored-by: Kumar Aditya <[email protected]>
Co-authored-by: Erlend Egeberg Aasland <[email protected]>
(cherry picked from commit 519eb6a)
@kumaraditya303 kumaraditya303 deleted the sqlite branch February 2, 2022 04:35
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@miss-islington @kumaraditya303 @hello-adam
bpo-45925: Update macOS installer to SQLite 3.37.2 (pythonGH-30921) (p…
4f70a2e 
…ythonGH-31057) (pythonGH-31059)

Co-authored-by: Kumar Aditya <[email protected]>
Co-authored-by: Erlend Egeberg Aasland <[email protected]>
(cherry picked from commit 519eb6a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@ned-deily ned-deily Awaiting requested review from ned-deily

Assignees

@ned-deily ned-deily

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@kumaraditya303 @miss-islington @ned-deily @AlexWaygood @bedevere-bot @erlend-aasland @hugovk @the-knights-who-say-ni