Skip to content

Comments

bpo-45925: Update Windows installer to SQLite 3.37.2#30485

Merged
zooba merged 4 commits intopython:mainfrom
kumaraditya303:issue45925
Jan 28, 2022
Merged

bpo-45925: Update Windows installer to SQLite 3.37.2#30485
zooba merged 4 commits intopython:mainfrom
kumaraditya303:issue45925

Conversation

@kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Jan 8, 2022 •
edited by bedevere-bot
Loading

@kumaraditya303 kumaraditya303 requested review from a team as code owners January 8, 2022 12:41
@erlend-aasland
Copy link
Contributor

erlend-aasland commented Jan 8, 2022

Please split this up in one PR for the Windows installer and one for the macOS installer.

Also, I usually wait with these PRs until approx. a month has passed. For example with SQLite 3.35, there was a series of five (!) patch releases before that branch stabilised.

I suggest to wait with updating the installers until we've seen that the SQLite 3.37 branch has calmed down :) Keep an eye on the SQLite forum and on the SQLite SCM. If you see mentions of 3.37.3, you'll know there's an upcoming patch release.

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Jan 8, 2022

The next 3.10 release is expected early February. I suggest to revisit updating the installers in approx. three weeks time.

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Jan 8, 2022

Nit: its macOS, not Mac, and SQLite, not sqlite 🤓

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Jan 25, 2022

@kumaraditya303 Can you split up this in a Windows PR and a macOS PR?

@kumaraditya303
Copy link
Contributor Author

kumaraditya303 commented Jan 26, 2022

@erlend-aasland Created #30921 Merge that first then I'll rebase.

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Jan 27, 2022 •
edited
Loading

@erlend-aasland Created #30921 Merge that first then I'll rebase.

Please just remove the macOS part from this PR so the two teams can do their reviews independently; the Windows PR does not depend on the macOS PR, and the other way around. I'll remove the macOS team from the review list.

Update PR title to this: Update Windows installer to use SQLite 3.37.2

@erlend-aasland erlend-aasland removed the request for review from a team January 27, 2022 09:33
erlend-aasland
erlend-aasland reviewed Jan 27, 2022
View reviewed changes
@kumaraditya303 kumaraditya303 requested review from erlend-aasland and removed request for a team January 28, 2022 05:35
@kumaraditya303 kumaraditya303 changed the title bpo-45925: Update Windows and Mac installers to sqlite 3.37.2 bpo-45925: Update Windows installer to SQLite 3.37.2 Jan 28, 2022
erlend-aasland
erlend-aasland approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LG

@erlend-aasland erlend-aasland requested review from a team and zooba January 28, 2022 07:39
@zooba
Copy link
Member

zooba commented Jan 28, 2022

LGTM

@zooba zooba merged commit db77bcd into python:main Jan 28, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Jan 28, 2022

Thanks @kumaraditya303 for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Jan 28, 2022

Thanks @kumaraditya303 for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Jan 28, 2022

Sorry, @kumaraditya303 and @zooba, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker db77bcd6092f3c174ae855522411ab83854d65a8 3.10

@miss-islington
Copy link
Contributor

miss-islington commented Jan 28, 2022

Sorry @kumaraditya303 and @zooba, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker db77bcd6092f3c174ae855522411ab83854d65a8 3.9

@bedevere-bot
Copy link

bedevere-bot commented Jan 28, 2022

GH-30991 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 28, 2022
zooba pushed a commit to zooba/cpython that referenced this pull request Jan 28, 2022
@kumaraditya303 @zooba
bpo-45925: Update Windows installer to SQLite 3.37.2 (pythonGH-30485)
3604782
zooba added a commit that referenced this pull request Jan 28, 2022
@zooba @kumaraditya303
bpo-45925: Update Windows installer to SQLite 3.37.2 (GH-30485)
4d191fc 
Co-authored-by: Kumar Aditya <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 28, 2022
@zooba @miss-islington
bpo-45925: Update Windows installer to SQLite 3.37.2 (pythonGH-30485)
f91f5d7 
Co-authored-by: Kumar Aditya <[email protected]>
(cherry picked from commit 4d191fc)

Co-authored-by: Steve Dower <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented Jan 28, 2022

GH-30994 is a backport of this pull request to the 3.9 branch.

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Jan 28, 2022

Thanks for merging and for fixing the backports, Steve!

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Jan 28, 2022

Thanks for the PR, Kumar!

@kumaraditya303 kumaraditya303 deleted the issue45925 branch January 28, 2022 17:44
miss-islington added a commit that referenced this pull request Jan 28, 2022
@miss-islington @zooba
bpo-45925: Update Windows installer to SQLite 3.37.2 (GH-30485)
ad9cf2f 
Co-authored-by: Kumar Aditya <[email protected]>
(cherry picked from commit 4d191fc)

Co-authored-by: Steve Dower <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented Jan 28, 2022 •
edited
Loading

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64LE CentOS9 3.9 has failed when building commit ad9cf2f.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/861/builds/3) and take a look at the build logs.
  4. Check if the failure is related to this commit (ad9cf2f) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/861/builds/3

Summary of the results of the build (if available):

Click to see traceback logs 
remote: Enumerating objects: 11, done.        
remote: Counting objects:  12% (1/8)        
remote: Counting objects:  25% (2/8)        
remote: Counting objects:  37% (3/8)        
remote: Counting objects:  50% (4/8)        
remote: Counting objects:  62% (5/8)        
remote: Counting objects:  75% (6/8)        
remote: Counting objects:  87% (7/8)        
remote: Counting objects: 100% (8/8)        
remote: Counting objects: 100% (8/8), done.        
remote: Total 11 (delta 7), reused 7 (delta 7), pack-reused 3        
From https://github.com/python/cpython
 * branch                  3.9        -> FETCH_HEAD
Note: switching to 'ad9cf2fdd39968b07e04136c8b50f65a4596c087'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at ad9cf2fdd3 [bpo-45925](https://bugs.python.org/issue45925): Update Windows installer to SQLite 3.37.2 (GH-30485)
Switched to and reset branch '3.9'

configure: WARNING: unrecognized options: --without-static-libpython
configure: WARNING: unrecognized options: --without-static-libpython

../Modules/signalmodule.c: In function ‘signal_siginterrupt_impl’:
../Modules/signalmodule.c:663:5: warning: ‘siginterrupt’ is deprecated: Use sigaction with SA_RESTART instead [-Wdeprecated-declarations]
  663 |     if (siginterrupt(signalnum, flag)<0) {
      |     ^~
In file included from ../Modules/signalmodule.c:28:
/usr/include/signal.h:324:12: note: declared here
  324 | extern int siginterrupt (int __sig, int __interrupt) __THROW
      |            ^~~~~~~~~~~~
ar: libpython3.9d.a: No space left on device
make: *** [Makefile:655: libpython3.9d.a] Error 1
make: *** Waiting for unfinished jobs....
lto1: fatal error: error writing to /tmp/ccCSs75n.s: No space left on device
compilation terminated.
lto-wrapper: fatal error: gcc returned 1 exit status
compilation terminated.
/usr/bin/ld: error: lto-wrapper failed
collect2: error: ld returned 1 exit status
ln: failed to access 'libpython3.9d.so.1.0': No such file or directory
make: *** [Makefile:658: libpython3.9d.so] Error 1

find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
make: [Makefile:1875: clean-retain-profile] Error 1 (ignored)

hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@miss-islington @zooba @hello-adam
bpo-45925: Update Windows installer to SQLite 3.37.2 (pythonGH-30485)
4d1572a 
Co-authored-by: Kumar Aditya <[email protected]>
(cherry picked from commit 4d191fc)

Co-authored-by: Steve Dower <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@zooba zooba Awaiting requested review from zooba

Assignees

@zooba zooba

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kumaraditya303 @erlend-aasland @zooba @miss-islington @bedevere-bot @the-knights-who-say-ni