Skip to content

bpo-46150: ensure fakename does not exist in PosixPathTest.test_expanduser#30240

Merged
gpshead merged 3 commits intopython:mainfrom
sobolevn:issue-46150
Dec 24, 2021
Merged

bpo-46150: ensure fakename does not exist in PosixPathTest.test_expanduser#30240
gpshead merged 3 commits intopython:mainfrom
sobolevn:issue-46150

Conversation

@sobolevn
Copy link
Copy Markdown
Member

@sobolevn sobolevn commented Dec 23, 2021 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Dec 23, 2021
kumaraditya303
kumaraditya303 approved these changes Dec 23, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@kumaraditya303 kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sobolevn
Copy link
Copy Markdown
Member Author

sobolevn commented Dec 23, 2021

CC @twouters

@kumaraditya303
Copy link
Copy Markdown
Contributor

kumaraditya303 commented Dec 24, 2021

#30244 is already merged and fixed this issue.

@sobolevn sobolevn mentioned this pull request Dec 24, 2021
Merged
@gpshead
Copy link
Copy Markdown
Member

gpshead commented Dec 24, 2021 •
edited
Loading

never the less, i like yours better. :) I didn't imagine anyone else would've run into this before so I didn't even search for a related issue or PR for my trivial "fix". [edit... my teammate filed the bug and I hadn't noticed, LOL]

Plus someone pointed out that the number I added to the name in my merged PR can be interpreted poorly... I'll go with this one.

@gpshead gpshead self-assigned this Dec 24, 2021
@gpshead gpshead merged commit b8de8b7 into python:main Dec 24, 2021
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Dec 24, 2021

Thanks @sobolevn for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 24, 2021
@sobolevn @miss-islington
bpo-46150: ensure fakeuser does not exist in `PosixPathTest.test_ex…
fbcceeb 
…panduser` (pythonGH-30240)

Ensure `fakeuser` does not exist in `PosixPathTest.test_expanduser`
(cherry picked from commit b8de8b7)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Dec 24, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 24, 2021
@sobolevn @miss-islington
bpo-46150: ensure fakeuser does not exist in `PosixPathTest.test_ex…
d69e16e 
…panduser` (pythonGH-30240)

Ensure `fakeuser` does not exist in `PosixPathTest.test_expanduser`
(cherry picked from commit b8de8b7)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Dec 24, 2021

GH-30248 is a backport of this pull request to the 3.10 branch.

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Dec 24, 2021

GH-30249 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Dec 24, 2021
@miss-islington @sobolevn
bpo-46150: ensure fakeuser does not exist in `PosixPathTest.test_ex…
8005e22 
…panduser` (GH-30240)

Ensure `fakeuser` does not exist in `PosixPathTest.test_expanduser`
(cherry picked from commit b8de8b7)

Co-authored-by: Nikita Sobolev <[email protected]>
miss-islington added a commit that referenced this pull request Dec 24, 2021
@miss-islington @sobolevn
bpo-46150: ensure fakeuser does not exist in `PosixPathTest.test_ex…
d718764 
…panduser` (GH-30240)

Ensure `fakeuser` does not exist in `PosixPathTest.test_expanduser`
(cherry picked from commit b8de8b7)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Dec 24, 2021

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 macOS 3.x has failed when building commit b8de8b7.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/725/builds/613) and take a look at the build logs.
  4. Check if the failure is related to this commit (b8de8b7) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/725/builds/613

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

411 tests OK.

10 slowest tests:

  • test_concurrent_futures: 3 min 39 sec
  • test_multiprocessing_spawn: 2 min 31 sec
  • test_multiprocessing_forkserver: 1 min 48 sec
  • test_unparse: 1 min 26 sec
  • test_asyncio: 1 min 18 sec
  • test_tokenize: 1 min 17 sec
  • test_logging: 1 min
  • test_lib2to3: 52.5 sec
  • test_capi: 48.5 sec
  • test_unicodedata: 47.3 sec

1 test altered the execution environment:
test_ftplib

17 tests skipped:
test_dbm_gnu test_devpoll test_epoll test_gdb test_ioctl
test_msilib test_multiprocessing_fork test_ossaudiodev test_spwd
test_startfile test_tix test_tk test_ttk_guionly test_winconsoleio
test_winreg test_winsound test_zipfile64

Total duration: 8 min 36 sec

Click to see traceback logs 
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
    ^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: '/psm_6bbf6674'


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
    ^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: '/psm_9459c633'


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncore.py", line 90, in read
    obj.handle_read_event()
    ^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ftplib.py", line 384, in handle_read_event
    self._do_ssl_handshake()
    ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ftplib.py", line 345, in _do_ssl_handshake
    self.socket.do_handshake()
    ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/ssl.py", line 1346, in do_handshake
    self._sslobj.do_handshake()
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^
ssl.SSLZeroReturnError: TLS/SSL connection has been closed (EOF) (_ssl.c:998)


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/threading.py", line 1031, in _bootstrap_inner
    self.run()
    ^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ftplib.py", line 298, in run
    asyncore.loop(timeout=0.1, count=1)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncore.py", line 214, in loop
    poll_fun(timeout, map)
    ^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncore.py", line 157, in poll
    read(obj)
    ^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncore.py", line 94, in read
    obj.handle_error()
    ^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ftplib.py", line 421, in handle_error
    raise Exception
    ^^^^^^^^^^^^^^^
Exception
k

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees

@gpshead gpshead

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sobolevn @kumaraditya303 @gpshead @miss-islington @bedevere-bot @the-knights-who-say-ni