bpo-45557: Fix underscore_numbers in pprint.pprint(). #29129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's no test for this, because in general the pprint module doesn't test |
zware
approved these changes
Oct 21, 2021
|
I created https://bugs.python.org/issue45559 for testing |
jpvincent1980
approved these changes
Oct 21, 2021
|
Thanks @ericvsmith for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 21, 2021
(cherry picked from commit 087f089) Co-authored-by: Eric V. Smith <[email protected]>
|
GH-29133 is a backport of this pull request to the 3.10 branch. |
miss-islington
added a commit
that referenced
this pull request
Oct 21, 2021
(cherry picked from commit 087f089) Co-authored-by: Eric V. Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pprint.pprint() always passes
underscore_numbers=Falseto pformat(), it should useunderscore_numbers=underscore_numbers.https://bugs.python.org/issue45557