Skip to content

Comments

no-issue: Make silence about warning '_POSIX_C_SOURCE redefined'#28948

Merged
corona10 merged 1 commit intopython:mainfrom
corona10:posix_warn
Oct 14, 2021
Merged

no-issue: Make silence about warning '_POSIX_C_SOURCE redefined'#28948
corona10 merged 1 commit intopython:mainfrom
corona10:posix_warn

Conversation

@corona10
Copy link
Member

@corona10 corona10 commented Oct 14, 2021 

In file included from /home/corona10/cpython/Modules/expat/expat_config.h:8,
                 from /home/corona10/cpython/Modules/expat/xmltok.c:53:
./pyconfig.h:1628: warning: "_POSIX_C_SOURCE" redefined
 #define _POSIX_C_SOURCE 200809L

In file included from /usr/include/bits/libc-header-start.h:33,
                 from /usr/include/string.h:26,
                 from /home/corona10/cpython/Modules/expat/xmltok.c:46:
/usr/include/features.h:294: note: this is the location of the previous definition
 # define _POSIX_C_SOURCE 199506L

tiran
tiran approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

Could you please propose the change upstream, too?

@corona10
Copy link
Member Author

corona10 commented Oct 14, 2021

@tiran
Do you mean https://github.com/libexpat/libexpat ?
If yes, sure :)

@corona10 corona10 merged commit d413c50 into python:main Oct 14, 2021
@miss-islington
Copy link
Contributor

miss-islington commented Oct 14, 2021

Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

miss-islington commented Oct 14, 2021

Sorry @corona10, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker d413c503636cde2a6ab0ada25dccb0134633a8e6 3.10

@bedevere-bot
Copy link

bedevere-bot commented Oct 14, 2021

GH-28949 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 14, 2021
@corona10 @miss-islington
no-issue: Make silence about warning '_POSIX_C_SOURCE redefined' (pyt…
eb65b96 
…honGH-28948)

(cherry picked from commit d413c50)

Co-authored-by: Dong-hee Na <[email protected]>
@corona10 corona10 mentioned this pull request Oct 14, 2021
Closed
@vstinner
Copy link
Member

vstinner commented Oct 14, 2021

Do you mean https://github.com/libexpat/libexpat ?

Yeah, Modules/expat/ is just a copy of it. We have like 2 or 3 lines of downstream patches.

corona10 added a commit to corona10/cpython that referenced this pull request Oct 14, 2021
@corona10
[3.10] no-issue: Make silence about warning '_POSIX_C_SOURCE redefine…
2534e40 
…d' (pythonGH-28948)

(cherry picked from commit d413c50)

Co-authored-by: Dong-hee Na <[email protected]>
@corona10 corona10 mentioned this pull request Oct 14, 2021
Merged
@bedevere-bot
Copy link

bedevere-bot commented Oct 14, 2021

GH-28951 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 14, 2021
@psphilippe psphilippe mentioned this pull request Oct 14, 2021
Merged
corona10 added a commit that referenced this pull request Oct 14, 2021
@corona10
[3.10] no-issue: Make silence about warning '_POSIX_C_SOURCE redefine…
70b150a 
…d' (GH-28948) (GH-28951)
miss-islington added a commit that referenced this pull request Oct 14, 2021
@miss-islington @corona10
no-issue: Make silence about warning '_POSIX_C_SOURCE redefined' (GH-…
38fadbc 
…28948)

(cherry picked from commit d413c50)

Co-authored-by: Dong-hee Na <[email protected]>
@corona10 corona10 deleted the posix_warn branch October 14, 2021 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiran tiran tiran approved these changes

@vstinner vstinner Awaiting requested review from vstinner

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees

@corona10 corona10

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@corona10 @miss-islington @bedevere-bot @vstinner @tiran @the-knights-who-say-ni