Skip to content

Fix typo#28814

Closed
MicaelJarniac wants to merge 1 commit intopython:3.10from
MicaelJarniac:patch-1
Closed

Fix typo#28814
MicaelJarniac wants to merge 1 commit intopython:3.10from
MicaelJarniac:patch-1

Conversation

@MicaelJarniac
Copy link
Copy Markdown
Contributor

Was still using List[...] instead of list[...].

Was still using `List[...]` instead of `list[...]`.
@the-knights-who-say-ni
Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@MicaelJarniac

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Oct 7, 2021
Copy link
Copy Markdown
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotta wait for your CLA (it takes a business day).

@Fidget-Spinner
Copy link
Copy Markdown
Member

The PR seems to be targetting the 3.10 branch. Could you please retarget it to the main branch? We can then backport it to 3.10 from there.

@MicaelJarniac
Copy link
Copy Markdown
Contributor Author

Sorry for the dozens of people I accidentally included here. I was just trying to change the target branch, didn't mean to include thousands of other files. :c

@Fidget-Spinner
Copy link
Copy Markdown
Member

Fidget-Spinner commented Oct 8, 2021

I tried to do this and I think I messed up heavily.

No worries, thanks for closing this PR and making a brand new one for main branch (I'll review and merge it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting merge docs Documentation in the Doc dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants