bpo-45020: Drop the frozen .h files from the repo.#28392
Merged
ericsnowcurrently merged 5 commits intopython:mainfrom Sep 16, 2021
Merged
bpo-45020: Drop the frozen .h files from the repo.#28392ericsnowcurrently merged 5 commits intopython:mainfrom
ericsnowcurrently merged 5 commits intopython:mainfrom
Conversation
ericsnowcurrently
requested review from
a team and
rhettinger
as code owners
ericsnowcurrently
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit b9d87111a6698b4825e4cf7c4355ee0f45902abf 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
46 tasks
ericsnowcurrently
force-pushed
the
frozen-modules-drop-h-files-again
branch
from
b9d8711 to
e7c9d0d
Compare
Member
Author
|
I'm going to watch the buildbots and make sure the earlier problem is resolved here. |
Member
|
FWIW, I kind of doubt that removing the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is essentially an un-revert of gh-28375 (reverted in gh-28380). I reverted it due to a (single) buildbot failure. I've adjusted the code we generate for frozen modules in the makefile, based on a hunch about the make version, to fix it.
(Note that I also remove the frozen
__hello__.hfile, which I missed in the original PR.)https://bugs.python.org/issue45020