bpo-41620: TestCase.run() now always return a TestResult instance #28030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it returned None if the test class or method was decorated with a skipping decorator.
serhiy-storchaka
added
type-bug
iritkatriel
approved these changes
Aug 29, 2021
Contributor
|
Thanks @serhiy-storchaka for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 30, 2021
…thonGH-28030) Previously it returned None if the test class or method was decorated with a skipping decorator. Co-authored-by: Iman Tabrizian <[email protected]> (cherry picked from commit 7e246a3) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-28064 is a backport of this pull request to the 3.10 branch. |
|
GH-28065 is a backport of this pull request to the 3.9 branch. |
Contributor
|
I credited Iman in the commit message. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 30, 2021
…thonGH-28030) Previously it returned None if the test class or method was decorated with a skipping decorator. Co-authored-by: Iman Tabrizian <[email protected]> (cherry picked from commit 7e246a3) Co-authored-by: Serhiy Storchaka <[email protected]>
ambv
pushed a commit
that referenced
this pull request
Aug 30, 2021
…-28030) (GH-28065) Previously it returned None if the test class or method was decorated with a skipping decorator. Co-authored-by: Iman Tabrizian <[email protected]> (cherry picked from commit 7e246a3) Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Aug 30, 2021
…-28030) Previously it returned None if the test class or method was decorated with a skipping decorator. Co-authored-by: Iman Tabrizian <[email protected]> (cherry picked from commit 7e246a3) Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it returned None if the test class or method was
decorated with a skipping decorator.
https://bugs.python.org/issue41620