Skip to content

Comments

bpo-45000: Raise SyntaxError when try to delete __debug__#27947

Merged
miss-islington merged 7 commits intopython:mainfrom
corona10:bpo-45000
Aug 25, 2021
Merged

bpo-45000: Raise SyntaxError when try to delete __debug__#27947
miss-islington merged 7 commits intopython:mainfrom
corona10:bpo-45000

Conversation

@corona10
Copy link
Member

@corona10 corona10 commented Aug 25, 2021 •
edited by miss-islington
Loading

@corona10 corona10 requested a review from markshannon as a code owner August 25, 2021 14:14
@corona10 corona10 changed the title bpo-45000: Make deleting __debug__ is forbidden bpo-45000: Raise SyntaxError when try to deleting __debug__ Aug 25, 2021
@corona10 corona10 requested a review from pablogsal August 25, 2021 14:18
@corona10
Copy link
Member Author

corona10 commented Aug 25, 2021 

0:00:00 load avg: 3.01 Run tests sequentially
0:00:00 load avg: 3.01 [1/1] test_syntax
beginning 6 repetitions
123456
......

== Tests result: SUCCESS ==

1 test OK.

Total duration: 1.5 sec
Tests result: SUCCESS

@corona10 corona10 changed the title bpo-45000: Raise SyntaxError when try to deleting __debug__ bpo-45000: Raise SyntaxError when try to delete __debug__ Aug 25, 2021
pablogsal
pablogsal reviewed Aug 25, 2021
View reviewed changes
pablogsal
pablogsal reviewed Aug 25, 2021
View reviewed changes
Doc/whatsnew/3.11.rst
support :class:`typing.SupportsComplex` and :class:`typing.SupportsBytes` protocols.
(Contributed by Mark Dickinson and Dong-hee Na in :issue:`24234`.)

* A :exc:`SyntaxError` (instead of a :exc:`NameError`) will be raised when deleting the :const:`__debug__` constant. (Contributed by Dong-hee Na in :issue:`45000`.)
Copy link
Member

@pablogsal pablogsal Aug 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should backport, so this needs to be moved to the 3.10 document

Copy link
Member

@pablogsal pablogsal Aug 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@corona10 I think you missed this message :)

Copy link
Member Author

@corona10 corona10 Aug 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you missed this message :)

@pablogsal Looks like due to auto-merge label :(

@miss-islington
Copy link
Contributor

miss-islington commented Aug 25, 2021

@corona10: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 551da59 into python:main Aug 25, 2021
corona10 added a commit to corona10/cpython that referenced this pull request Aug 26, 2021
@corona10
bpo-45000: Raise SyntaxError when try to delete __debug__ (pythonGH-2…
fd94f63 
…7947)

(cherry picked from commit 551da59)
pablogsal pushed a commit that referenced this pull request Aug 26, 2021
@corona10
bpo-45000: Raise SyntaxError when try to delete __debug__ (GH-27947) (G…
32c1caa 
…H-27957)

(cherry picked from commit 551da59)
@corona10 corona10 deleted the bpo-45000 branch August 26, 2021 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@corona10 @miss-islington @pablogsal @the-knights-who-say-ni @bedevere-bot