bpo-44553 : Implement GC methods for types.Union#26993
Merged
serhiy-storchaka merged 3 commits intopython:mainfrom Jul 3, 2021
Merged
bpo-44553 : Implement GC methods for types.Union#26993serhiy-storchaka merged 3 commits intopython:mainfrom
serhiy-storchaka merged 3 commits intopython:mainfrom
Conversation
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
LGTM. I have just few nitpicks to the tests.
serhiy-storchaka
approved these changes
Jul 3, 2021
Contributor
|
Thanks @Fidget-Spinner for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 3, 2021
(cherry picked from commit 1097384) Co-authored-by: Ken Jin <[email protected]>
|
GH-27002 is a backport of this pull request to the 3.10 branch. |
miss-islington
added a commit
that referenced
this pull request
Jul 3, 2021
(cherry picked from commit 1097384) Co-authored-by: Ken Jin <[email protected]>
Member
pablogsal
reviewed
Jul 3, 2021
| result->args = dedup_and_flatten_args(args); | ||
| if (result->args == NULL) { | ||
| Py_DECREF(result); | ||
| PyObject_GC_Del(result); |
Member
There was a problem hiding this comment.
This is incorrect, this should still be Py_DECREF, PyObject_GC_Del cannot be called like that because it overrides a bunch of cleanups like the call to _Py_ForgetReference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue44553