bpo-43921: Fix test_ssl.test_wrong_cert_tls13() on Windows#26502
Merged
vstinner merged 1 commit intopython:mainfrom Jun 3, 2021
vstinner:test_ssl2
Merged
bpo-43921: Fix test_ssl.test_wrong_cert_tls13() on Windows#26502vstinner merged 1 commit intopython:mainfrom vstinner:test_ssl2
vstinner merged 1 commit intopython:mainfrom
vstinner:test_ssl2
Conversation
Fix test_ssl.test_wrong_cert_tls13(): use suppress_ragged_eofs=False, since read() can raise ssl.SSLEOFError on Windows.
vstinner
added
needs backport to 3.10
Member
Author
|
See #26501 (comment) for my debug notes on this issue. |
Member
Author
|
cc @tiran @pablogsal: a PR fixing test_wrong_cert_tls13() similar to (but different than) my previous PR #26489 fixing test_pha_required_nocert(). |
Contributor
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
Contributor
|
Sorry @vstinner, I had trouble checking out the |
vstinner
added
needs backport to 3.10
Contributor
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
|
GH-26518 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 3, 2021
…26502) Fix test_ssl.test_wrong_cert_tls13(): use suppress_ragged_eofs=False, since read() can raise ssl.SSLEOFError on Windows. (cherry picked from commit ea0210f) Co-authored-by: Victor Stinner <[email protected]>
vstinner
added a commit
that referenced
this pull request
Jun 3, 2021
…GH-26518) Fix test_ssl.test_wrong_cert_tls13(): use suppress_ragged_eofs=False, since read() can raise ssl.SSLEOFError on Windows. (cherry picked from commit ea0210f) Co-authored-by: Victor Stinner <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix test_ssl.test_wrong_cert_tls13(): use suppress_ragged_eofs=False,
since read() can raise ssl.SSLEOFError on Windows.
https://bugs.python.org/issue43921