bpo-43988: Use check disallow instantiation helper #26392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erlend-aasland
changed the title
added 3 commits
May 27, 2021 00:50
vstinner
reviewed
May 26, 2021
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
I suggest to avoid tp = ... and then use tp, since "tp" name doesn't help: use directly "...". I wrote some examples.
Member
|
Merged, thanks. This helper makes me more confident that the test actually checks that the type is immutable. |
Contributor
Author
Great, thanks for reviewing and improving the PR! |
erlend-aasland
pushed a commit
to erlend-aasland/cpython
that referenced
this pull request
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue43988