bpo-43913: Fix unittest module cleanup #25700
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
| previousModule) | ||
| finally: | ||
| _call_if_exists(result, '_restoreStdout') | ||
| try: |
There was a problem hiding this comment.
Should it also be called in this finally block? That's the previous behavior, and I imagine it could be important to ensure it's called even when tearDownModule() raises a BaseException.
There was a problem hiding this comment.
Thanks for the suggestion. I think this is not need TBH, my understanding it that the finally block will be executed anyways in case of a Exception and, since _call_if_exists doesn't return, the clean up is done in the following steps.
Regarding the BaseException, yes, if tearDownModule raises it no doModuleCleanups is performed.
I think it's a good idea to catch it but for consistency we should change setUpClass as well. What do you think?
setUpClass = getattr(currentClass, 'setUpClass', None)
if setUpClass is not None:
_call_if_exists(result, '_setupStdout')
try:
setUpClass()
except Exception as e:
if isinstance(result, _DebugResult):
raise`
Co-authored-by: Jelle Zijlstra <[email protected]>
|
This PR is stale because it has been open for 30 days with no activity. |
|
Closing in favor of GH-28006. |
5 participants
This is my my attempt to fix the bug described in https://bugs.python.org/issue43913
https://bugs.python.org/issue43913