bpo-41515: Fix assert in test which throws SyntaxWarning.#25379
Merged
gvanrossum merged 1 commit intopython:masterfrom Apr 13, 2021
Merged
bpo-41515: Fix assert in test which throws SyntaxWarning.#25379gvanrossum merged 1 commit intopython:masterfrom
gvanrossum merged 1 commit intopython:masterfrom
Conversation
gvanrossum
approved these changes
Apr 13, 2021
Member
gvanrossum
left a comment
There was a problem hiding this comment.
Did you verify this using the test strategy Victor gave?
Member
Author
|
Yes, I have verified that the PR fixes the warning. On master branch With patch Additionally this can be reproduced on test_typing by turning on -Werror On master With patch |
Member
|
Sorry I didn't catch this when reviewing the original :(, and thanks for the quick fix! |
|
@gvanrossum: Please replace |
Member
Don't worry. As I explained, it was silently ignored by the CI: https://bugs.python.org/issue41515#msg390893 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue41515