Skip to content

bpo-41361: Optimized argument parsing for deque_rotate #24796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rhettinger merged 3 commits into from
Mar 16, 2021
Merged

bpo-41361: Optimized argument parsing for deque_rotate #24796

rhettinger merged 3 commits into from
Mar 16, 2021

Conversation

@sweeneyde
Copy link
Member

@sweeneyde sweeneyde commented Mar 9, 2021 •
edited by bedevere-bot
Loading

@sweeneyde sweeneyde requested a review from rhettinger as a code owner March 9, 2021 05:18
@sweeneyde
Copy link
Member Author

sweeneyde commented Mar 13, 2021

@rhettinger FWIW, with the refleak fixed, I got these benchmarks

Before, with PGO:

    rotate()   --> Mean +- std dev: 50.3 ns +- 1.9 ns
    rotate(1)  --> Mean +- std dev: 61.9 ns +- 2.7 ns
    rotate(-1) --> Mean +- std dev: 63.7 ns +- 0.8 ns

After, with PGO:

    rotate()   --> Mean +- std dev: 40.9 ns +- 0.4 ns
    rotate(1)  --> Mean +- std dev: 46.9 ns +- 0.3 ns
    rotate(-1) --> Mean +- std dev: 47.4 ns +- 0.3 ns

@rhettinger rhettinger merged commit 448801d into python:master Mar 16, 2021
@sweeneyde sweeneyde deleted the deque_rotate branch December 19, 2021 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettinger rhettinger rhettinger approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sweeneyde @rhettinger @the-knights-who-say-ni @bedevere-bot