bpo-40455: Fix gcc10+ warning about writing into a section of offset 0 #24384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This silences this warnings: Objects/codeobject.c:414:15: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=] 414 | *lnotab++ = b;
corona10
approved these changes
Jan 30, 2021
Member
corona10
left a comment
corona10
left a comment
There was a problem hiding this comment.
I locally check this work on my gcc10 machine and the patch works well :)
Contributor
|
Thanks @pablogsal for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
Contributor
|
Sorry, @pablogsal and @corona10, I could not cleanly backport this to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This silences this warnings:
Objects/codeobject.c:414:15: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
414 | *lnotab++ = b;
https://bugs.python.org/issue40455