bpo-43049: Use io.IncrementalNewlineDecoder for doctest newline conversion#24359
Merged
zware merged 1 commit intopython:masterfrom Mar 2, 2021
Merged
bpo-43049: Use io.IncrementalNewlineDecoder for doctest newline conversion#24359zware merged 1 commit intopython:masterfrom
zware merged 1 commit intopython:masterfrom
Conversation
merwok
changed the title
Member
|
No new test is needed because existing tests already cover this code, is that correct? |
Contributor
Author
Yes, that's correct. |
zware
approved these changes
Jan 28, 2021
|
This PR is stale because it has been open for 30 days with no activity. |
Contributor
Author
|
Just saw the stale notification, bumping to get an update on merging this PR. |
github-actions
bot
removed
the
stale
Member
|
I was leaving this for anyone more familiar with either |
|
Member
|
I'm going to declare that buildbot failure Not Our Fault™ :). I also got an email about a Ubuntu check failure, which also appears unrelated to this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to PR #17385 for bpo-1812 (now merged). During discussion on that issue the suggestion was made to investigate whether any resources already provided by the io module might be available to do the newline conversion in doctest that was corrected in that PR. It turns out there is: the io.IncrementalNewlineDecoder object does exactly the conversion that is needed. This PR implements using that object in place of the custom newline conversion that was done in the previous PR. The only change is in the relevant code in the doctest module.
https://bugs.python.org/issue43049