Skip to content

[2.7] bpo-30764: test_subprocess uses SuppressCrashReport (#2405) #2412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 2 commits into from
Jun 26, 2017
Merged

[2.7] bpo-30764: test_subprocess uses SuppressCrashReport (#2405) #2412

vstinner merged 2 commits into from
Jun 26, 2017

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Jun 26, 2017

Backport also test.support.SuppressCrashReport.

vstinner added 2 commits June 26, 2017 18:11
@vstinner
bpo-30764: Backport support.SuppressCrashReport
ca65ccc 
Backport test.support.SuppressCrashReport context-manager from
master. Drop the Windows implementation since it depends on
msvcrt.CrtSetReportMode() which isn't available on Python 2.7.
@vstinner
bpo-30764: test_subprocess uses SuppressCrashReport (#2405)
ba28878 
bpo-30764, bpo-29335: test_child_terminated_in_stopped_state() of
test_subprocess now uses support.SuppressCrashReport() to prevent the
creation of a core dump on FreeBSD.
(cherry picked from commit cdee3f1)
@vstinner
Copy link
Member Author

vstinner commented Jun 26, 2017

I backported the Windows implementation of test.support.SuppressCrashReport, but I prefer to write a separated PR for that, since it adds C code and so is very different from this change.

@vstinner vstinner changed the title bpo-30764: test_subprocess uses SuppressCrashReport (#2405) [2.7] bpo-30764: test_subprocess uses SuppressCrashReport (#2405) Jun 26, 2017
@vstinner vstinner merged commit 2097b9e into python:2.7 Jun 26, 2017
@vstinner vstinner deleted the subprocess_stopped27 branch June 26, 2017 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner @the-knights-who-say-ni