Skip to content

Conversation

@lysnikolaou
Copy link
Member

@lysnikolaou lysnikolaou commented Oct 31, 2020

Copy link
Member

@ericvsmith ericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Do you want to backport to 3.9 and 3.8?

@lysnikolaou
Copy link
Member Author

lysnikolaou commented Oct 31, 2020

Looks good to me. Do you want to backport to 3.9 and 3.8?

I guess it makes sense to do so, yeah. What do you think?

@lysnikolaou lysnikolaou merged commit 3018228 into python:master Nov 2, 2020
@miss-islington
Copy link
Contributor

Thanks @lysnikolaou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@lysnikolaou lysnikolaou deleted the test-format-locale-fix branch November 2, 2020 15:27
@miss-islington
Copy link
Contributor

Sorry @lysnikolaou, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 301822859b3fc34801a06f1090d62f9f2ee5b092 3.9

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 2, 2020
@bedevere-bot
Copy link

GH-23110 is a backport of this pull request to the 3.8 branch.

lysnikolaou added a commit to lysnikolaou/cpython that referenced this pull request Nov 2, 2020
…rouping (pythonGH-23067)

(cherry picked from commit 3018228)

Co-authored-by: Lysandros Nikolaou <[email protected]>
@bedevere-bot
Copy link

GH-23111 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Nov 2, 2020
lysnikolaou added a commit that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants