Skip to content

get up to date #22429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sumagnadas wants to merge 6 commits into from
Closed

get up to date #22429

sumagnadas wants to merge 6 commits into from

Conversation

@sumagnadas
Copy link

@sumagnadas sumagnadas commented Sep 27, 2020

No description provided.

larsoner and others added 6 commits September 28, 2020 00:19
@larsoner @sumagnadas
Fix logging error message (GH-22410)
e9d3951 
Same changes as #22276 squashed to a single commit. Just hoping to get Travis to cooperate by opening a new PR...

Automerge-Triggered-By: @vsajip
@vstinner @sumagnadas
bpo-41428: Fix compiler warning in unionobject.c (GH-22416)
d6a7cf1 
Use Py_ssize_t type rather than int, to store lengths in
unionobject.c. Fix the warning:

Objects\unionobject.c(205,1): warning C4244: 'initializing':
conversion from 'Py_ssize_t' to 'int', possible loss of data
@corona10 @sumagnadas
bpo-1635741: Port _bisect module to multi-phase init (GH-22415)
b78823c
@andresdelfino @sumagnadas
Revert "Fix all Python Cookbook links (#22205)" (GH-22424)
5109296 
This commit reverts commit ac0333e as the original links are working again and they provide extended features such as comments and alternative versions.
@eamanu @sumagnadas
bpo-41858: Clarify line in optparse doc (GH-22407)
23e8b56 
The existing line is easily read as being incomplete.
@sumagnadas
bpo-41861: Convert _sqlite3 cache and node static types to heap types (…
2375657 
…GH-22417)
@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented Sep 27, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@sumagnadas

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@sumagnadas
Copy link
Author

sumagnadas commented Sep 27, 2020

i wanted to create a pull request in my fork to get it updated and accidentally created it here. Sorry for the disturbances

@sumagnadas sumagnadas closed this Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou

@pablogsal pablogsal Awaiting requested review from pablogsal

@rhettinger rhettinger Awaiting requested review from rhettinger

@vsajip vsajip Awaiting requested review from vsajip

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@sumagnadas @the-knights-who-say-ni @bedevere-bot @larsoner @vstinner @corona10 @andresdelfino @eamanu