bpo-32682: Lib/test/test_zlib, fix version string handling#22361
bpo-32682: Lib/test/test_zlib, fix version string handling#22361pmp-p wants to merge 1 commit intopython:mainfrom pmp-p:bpo-32682
Conversation
| v.append('0') | ||
| elif not v[-1].isnumeric(): | ||
| v[-1] = '0' | ||
|
|
There was a problem hiding this comment.
These 5 lines appear also in test_wbits, wouldn't it be better to extract them into a helper function?
There was a problem hiding this comment.
maybe, i'll have a look if i or someone make an android buildbot someday and/or have some time left and testsuite can actually run.
iritkatriel
left a comment
iritkatriel
left a comment
There was a problem hiding this comment.
This PR is missing a test. See also https://github.com/python/cpython/pull/22361/files#r495475106.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
That was for passing testsuite on android 4.4 kitkat. I think no one care anymore now with WebAssembly available everywhere. Feel free to close or ask the PSF android grant recipient if they want to take on as I still provide patches for api19. |
|
Thanks. |
5 participants
Complete the original fix with the same code, extracting version number is done in more places than expected
https://bugs.python.org/issue32682