Skip to content

[3.9] bpo-41631: Fix a compiler warning in pycore_pylifecycle.h #22331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pablogsal merged 1 commit into from
Sep 21, 2020
Merged

[3.9] bpo-41631: Fix a compiler warning in pycore_pylifecycle.h #22331

pablogsal merged 1 commit into from
Sep 21, 2020

Conversation

@pablogsal
Copy link
Member

@pablogsal pablogsal commented Sep 20, 2020 •
edited
Loading

https://bugs.python.org/issue41631

This PR suppress this warning introduced in 55e0836:

./Include/internal/pycore_pylifecycle.h:85:24: warning: this function declaration is not 1 warning generated.
a prototype [-Wstrict-prototypes]
extern void _PyAST_Fini();
                       ^
                        void

@pablogsal pablogsal requested a review from ambv September 20, 2020 22:16
@pablogsal pablogsal self-assigned this Sep 20, 2020
@pablogsal pablogsal requested a review from vstinner September 20, 2020 22:17
@pablogsal
Copy link
Member Author

pablogsal commented Sep 21, 2020

CC: @ambv

vstinner
vstinner approved these changes Sep 21, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pablogsal: You can merge it, and then ask @ambv to include it in 3.9.0 final.

@pablogsal pablogsal merged commit 724df83 into python:3.9 Sep 21, 2020
@pablogsal pablogsal deleted the warning branch September 21, 2020 10:57
@ambv
Copy link
Contributor

ambv commented Oct 4, 2020

Done.

ambv pushed a commit to ambv/cpython that referenced this pull request Oct 4, 2020
@pablogsal @ambv
Fix a compiler warning in pycore_pylifecycle.h (pythonGH-22331)
d636089
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@corona10 corona10 corona10 approved these changes

@ambv ambv Awaiting requested review from ambv

Assignees

@pablogsal pablogsal

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pablogsal @ambv @vstinner @corona10 @the-knights-who-say-ni @bedevere-bot