Skip to content

Conversation

@madebr
Copy link
Contributor

@madebr madebr commented Aug 21, 2020

@madebr
Copy link
Contributor Author

madebr commented Aug 21, 2020

I accidentally copied the wrong bug id,
It should be https://bugs.python.org/issue41604
I'll force push a fix tomorrow.

@madebr madebr force-pushed the panel_set_userptr branch from 64bfd04 to 39a4378 Compare August 21, 2020 13:25
@serhiy-storchaka serhiy-storchaka added needs backport to 3.8 type-bug An unexpected behavior, bug, or error labels Jan 6, 2021
@serhiy-storchaka serhiy-storchaka changed the title bpo-1723038: Don't decrement the reference count of the previous user_ptr when set_panel_usertpr fails bpo-41604: Don't decrement the reference count of the previous user_ptr when set_panel_usertpr fails Jan 31, 2021
@serhiy-storchaka serhiy-storchaka merged commit 3243e8a into python:master Jan 31, 2021
@miss-islington
Copy link
Contributor

Thanks @madebr for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @madebr and @serhiy-storchaka, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 3243e8a4b4b4cf321f9b28335d565742a34b1976 3.9

@miss-islington
Copy link
Contributor

Sorry @madebr and @serhiy-storchaka, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 3243e8a4b4b4cf321f9b28335d565742a34b1976 3.8

serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Jan 31, 2021
…user_ptr when set_panel_usertpr fails (pythonGH-21933).

(cherry picked from commit 3243e8a)

Co-authored-by: Anonymous Maarten <[email protected]>
@bedevere-bot
Copy link

GH-24403 is a backport of this pull request to the 3.9 branch.

@serhiy-storchaka serhiy-storchaka removed their assignment Jan 31, 2021
@madebr madebr deleted the panel_set_userptr branch January 31, 2021 19:01
serhiy-storchaka added a commit that referenced this pull request Jan 31, 2021
…user_ptr when set_panel_usertpr fails (GH-21933). (GH-24403)

(cherry picked from commit 3243e8a)

Co-authored-by: Anonymous Maarten <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 31, 2021
…user_ptr when set_panel_usertpr fails (pythonGH-21933). (pythonGH-24403)

(cherry picked from commit 3243e8a)

Co-authored-by: Anonymous Maarten <[email protected]>
(cherry picked from commit 3c8d693)

Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington added a commit that referenced this pull request Jan 31, 2021
…user_ptr when set_panel_usertpr fails (GH-21933). (GH-24403)

(cherry picked from commit 3243e8a)

Co-authored-by: Anonymous Maarten <[email protected]>
(cherry picked from commit 3c8d693)

Co-authored-by: Serhiy Storchaka <[email protected]>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@ffrederick ffrederick mannequin mentioned this pull request Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants