bpo-40924: Ensure importlib.resources.path returns an extant path#20857
Merged
ambv merged 2 commits intopython:masterfrom Jun 29, 2020
jaraco:bpo-40924/restore-leaky-path
Merged
bpo-40924: Ensure importlib.resources.path returns an extant path#20857ambv merged 2 commits intopython:masterfrom jaraco:bpo-40924/restore-leaky-path
ambv merged 2 commits intopython:masterfrom
jaraco:bpo-40924/restore-leaky-path
Conversation
… the SourceFileLoader's resource reader.
warsaw
reviewed
Jun 15, 2020
|
|
||
|
|
||
| class ZipReader(FileReader): | ||
| class ZipReader(abc.TraversableResources): |
Member
There was a problem hiding this comment.
Is this a safe (as in backward-compatible) change?
Member
Author
There was a problem hiding this comment.
Yes. The main reason this was here was to supply FileReader.files, but now it has its own copy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure
importlib.resources.pathreturns an extant path for the SourceFileLoader's resource reader. Avoids the regression identified in bpo-40924 in master while a long-term solution is devised.https://bugs.python.org/issue40924