bpo-40769: allow extra surrounding parentheses for invalid annotated assignment rule#20387
Merged
pablogsal merged 1 commit intopython:masterfrom Jun 27, 2020
Merged
bpo-40769: allow extra surrounding parentheses for invalid annotated assignment rule#20387pablogsal merged 1 commit intopython:masterfrom
pablogsal merged 1 commit intopython:masterfrom
Conversation
lysnikolaou
approved these changes
May 26, 2020
Member
lysnikolaou
left a comment
lysnikolaou
left a comment
There was a problem hiding this comment.
LGTM! Thanks. (You will probably need to regenerate parse.c)
lysnikolaou
reviewed
May 26, 2020
Member
|
@isidentical @pablogsal Friendly ping. |
Member
Author
|
rebased to upstream |
Member
Author
|
I've rebased again, CC: @pablogsal |
pablogsal
approved these changes
Jun 27, 2020
Contributor
|
Thanks @isidentical for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
Contributor
|
Sorry, @isidentical and @pablogsal, I could not cleanly backport this to |
pablogsal
pushed a commit
to pablogsal/cpython
that referenced
this pull request
Jun 27, 2020
…tated assignment rule (pythonGH-20387). (cherry picked from commit c8f29ad) Co-authored-by: Batuhan Taskaya <[email protected]>
|
GH-21186 is a backport of this pull request to the 3.9 branch. |
pablogsal
added a commit
that referenced
this pull request
Jun 27, 2020
fasih
pushed a commit
to fasih/cpython
that referenced
this pull request
Jun 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue40769