bpo-40716: Improve error messages for trailing comma on from import #20294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Wrong issue number? |
Member
Author
yep! It should be 40716 |
isidentical
changed the title
lysnikolaou
reviewed
May 21, 2020
Member
|
You need to regenerate the parser 😉 |
pablogsal
reviewed
May 21, 2020
pablogsal
approved these changes
May 21, 2020
Contributor
|
Thanks @isidentical for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
Contributor
|
Sorry @isidentical and @pablogsal, I had trouble checking out the |
pablogsal
pushed a commit
to pablogsal/cpython
that referenced
this pull request
May 21, 2020
…port (pythonGH-20294) (cherry picked from commit 72e0aa2) Co-authored-by: Batuhan Taskaya <[email protected]>
|
GH-20302 is a backport of this pull request to the 3.9 branch. |
pablogsal
added a commit
that referenced
this pull request
May 21, 2020
…port (GH-20294) (GH-20302) (cherry picked from commit 72e0aa2) Co-authored-by: Batuhan Taskaya <[email protected]>
arturoescaip
pushed a commit
to arturoescaip/cpython
that referenced
this pull request
May 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue40716