bpo-40696: Fix a hang that can arise after gen.throw()#20287
Merged
cjerdonek merged 5 commits intopython:masterfrom May 22, 2020
Merged
bpo-40696: Fix a hang that can arise after gen.throw()#20287cjerdonek merged 5 commits intopython:masterfrom
cjerdonek merged 5 commits intopython:masterfrom
Conversation
cjerdonek
changed the title
1st1
reviewed
May 21, 2020
1st1
reviewed
May 21, 2020
1st1
reviewed
May 21, 2020
1st1
reviewed
May 21, 2020
1st1
reviewed
May 21, 2020
Member
1st1
left a comment
1st1
left a comment
There was a problem hiding this comment.
I've left a few comments, Chris.
cjerdonek
force-pushed
the
issue-40696-await-hang
branch
from
a5084a9 to
66c71aa
Compare
Member
Author
|
@1st1 I made some changes. Let me know what you think. Happy to iterate further. |
1st1
approved these changes
May 22, 2020
Contributor
|
Thanks @cjerdonek for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 22, 2020
This updates _PyErr_ChainStackItem() to use _PyErr_SetObject() instead of _PyErr_ChainExceptions(). This prevents a hang in certain circumstances because _PyErr_SetObject() performs checks to prevent cycles in the exception context chain while _PyErr_ChainExceptions() doesn't. (cherry picked from commit 7c30d12) Co-authored-by: Chris Jerdonek <[email protected]>
|
GH-20321 is a backport of this pull request to the 3.9 branch. |
Contributor
|
Thanks @cjerdonek for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 22, 2020
This updates _PyErr_ChainStackItem() to use _PyErr_SetObject() instead of _PyErr_ChainExceptions(). This prevents a hang in certain circumstances because _PyErr_SetObject() performs checks to prevent cycles in the exception context chain while _PyErr_ChainExceptions() doesn't. (cherry picked from commit 7c30d12) Co-authored-by: Chris Jerdonek <[email protected]>
|
GH-20322 is a backport of this pull request to the 3.9 branch. |
cjerdonek
added a commit
that referenced
this pull request
May 22, 2020
This updates _PyErr_ChainStackItem() to use _PyErr_SetObject() instead of _PyErr_ChainExceptions(). This prevents a hang in certain circumstances because _PyErr_SetObject() performs checks to prevent cycles in the exception context chain while _PyErr_ChainExceptions() doesn't. (cherry picked from commit 7c30d12) Co-authored-by: Chris Jerdonek <[email protected]>
arturoescaip
pushed a commit
to arturoescaip/cpython
that referenced
this pull request
May 24, 2020
This updates _PyErr_ChainStackItem() to use _PyErr_SetObject() instead of _PyErr_ChainExceptions(). This prevents a hang in certain circumstances because _PyErr_SetObject() performs checks to prevent cycles in the exception context chain while _PyErr_ChainExceptions() doesn't.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue40696